Update return type for optimizer.apply #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #850 +/- ##
==========================================
- Coverage 75.99% 69.33% -6.67%
==========================================
Files 328 328
Lines 31099 31099
Branches 6051 6051
==========================================
- Hits 23635 21561 -2074
- Misses 5866 8033 +2167
+ Partials 1598 1505 -93
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Keeps a parallel API between optimizer.apply and optimizer.stateless_apply. We can leave the iterations return type on apply_gradients for compat with tf.keras.
mattdangerw
force-pushed
the
update-return-type
branch
from
cbc3fb2 to
110a256
Compare
|
The torch failure here looks unrelated. Could it be a flake? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style nit, remove return type from
optimizer.apply, so it is 1-1 with the signature foroptimizer.stateless_apply. We can leave the iterations return type onapply_gradientsfor compat with tf.keras. It seems mostly for compat, and has no stateless version.