Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_layer_test also runs symbolic calls when input_data is provided. #870

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

hertschuh
Copy link
Collaborator

This uncovered an issue in one layer and an issue in a test.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 76.92% and project coverage change: +0.03% 🎉

Comparison is base (50c5f9a) 76.40% compared to head (9563dc1) 76.43%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
+ Coverage   76.40%   76.43%   +0.03%     
==========================================
  Files         329      329              
  Lines       31327    31333       +6     
  Branches     6095     6100       +5     
==========================================
+ Hits        23934    23949      +15     
+ Misses       5809     5803       -6     
+ Partials     1584     1581       -3     
Flag Coverage Δ
keras_core 76.33% <76.92%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
keras_core/layers/preprocessing/hashed_crossing.py 77.92% <50.00%> (+3.56%) ⬆️
keras_core/testing/test_case.py 85.90% <81.81%> (-0.53%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hertschuh hertschuh requested a review from fchollet September 12, 2023 20:19
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

keras_core/testing/test_case.py Outdated Show resolved Hide resolved
This uncovered an issue in one layer and an issue in a test.
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fchollet fchollet merged commit ac8a204 into keras-team:main Sep 13, 2023
@hertschuh hertschuh deleted the symbolic_test branch September 13, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants