Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dtypes. #887

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Add missing dtypes. #887

merged 2 commits into from
Sep 15, 2023

Conversation

gleize
Copy link
Contributor

@gleize gleize commented Sep 14, 2023

My model contains some uint non trainable variables that triggered an exception when calling the model.summary() method.

I added the missing dtypes.

My model contains some `uint` non trainable variables that triggered an exception when calling the `model.summary()` method.

I added the missing dtypes.
@google-cla
Copy link

google-cla bot commented Sep 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (94b5361) 76.56% compared to head (6db20a4) 76.56%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
- Coverage   76.56%   76.56%   -0.01%     
==========================================
  Files         329      329              
  Lines       31429    31423       -6     
  Branches     6114     6111       -3     
==========================================
- Hits        24064    24058       -6     
  Misses       5786     5786              
  Partials     1579     1579              
Flag Coverage Δ
keras_core 76.46% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
keras_core/utils/dtype_utils.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fchollet fchollet merged commit 4cd003b into keras-team:main Sep 15, 2023
@gleize gleize deleted the patch-1 branch September 15, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants