Refactor merging layers tests as parametrized tests. #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hertschuh
force-pushed
the
merging_tests
branch
from
5322f1c to
1c9e80d
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
==========================================
+ Coverage 83.62% 83.63% +0.01%
==========================================
Files 318 318
Lines 28391 28391
Branches 5409 5409
==========================================
+ Hits 23741 23745 +4
+ Misses 3150 3147 -3
+ Partials 1500 1499 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
They are almost identical for every merging layer. This simplifies adding tests that apply to every layer. This is in preparation for adding sparse tensors support.
hertschuh
force-pushed
the
merging_tests
branch
from
1c9e80d to
b6143c4
Compare
fchollet
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are almost identical for every merging layer.
This simplifies adding tests that apply to every layer. This is in preparation for adding sparse tensors support.