Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix torch error for bincount #927

Merged
merged 7 commits into from
Sep 20, 2023

Conversation

divyashreepathihalli
Copy link
Collaborator

No description provided.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

keras_core/layers/preprocessing/discretization_test.py Outdated Show resolved Hide resolved
keras_core/utils/numerical_utils.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 96.96% and project coverage change: -4.98% ⚠️

Comparison is base (a92593f) 83.69% compared to head (8739f8c) 78.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #927      +/-   ##
==========================================
- Coverage   83.69%   78.71%   -4.98%     
==========================================
  Files         318      318              
  Lines       28735    28760      +25     
  Branches     5483     5488       +5     
==========================================
- Hits        24049    22639    -1410     
- Misses       3168     4674    +1506     
+ Partials     1518     1447      -71     
Flag Coverage Δ
keras_core 78.65% <96.96%> (-4.94%) ⬇️
keras_core-jax 67.00% <36.36%> (-0.04%) ⬇️
keras_core-numpy 60.32% <42.42%> (+0.01%) ⬆️
keras_core-tensorflow ?
keras_core-torch 69.12% <48.48%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
keras_core/layers/preprocessing/discretization.py 82.35% <ø> (ø)
keras_core/utils/numerical_utils.py 84.48% <83.33%> (ø)
keras_core/backend/jax/numpy.py 98.83% <100.00%> (+0.02%) ⬆️
keras_core/backend/numpy/numpy.py 98.73% <100.00%> (+0.03%) ⬆️
keras_core/backend/torch/numpy.py 95.25% <100.00%> (+0.07%) ⬆️

... and 39 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@divyashreepathihalli divyashreepathihalli marked this pull request as draft September 20, 2023 05:56
@divyashreepathihalli divyashreepathihalli marked this pull request as ready for review September 20, 2023 06:06
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

keras_core/backend/jax/numpy.py Outdated Show resolved Hide resolved
@fchollet
Copy link
Contributor

Also -- I've disabled the failing test yesterday for NumPy and torch, please reenable it.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@fchollet fchollet merged commit 4c3697f into keras-team:main Sep 20, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants