-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a vocabulary_size argument to UnicodeCharacterTokenizer #163
Conversation
@mattdangerw I think the PR is ready for review now. Here's a demo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks great. Just a few comments then this is ready to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks. Added a little more to the example to show how it could be used.
…keras-team#163)" This reverts commit a2c6067.
Fixes #155
I've also added new tests and fixed old tests by modifying the config files with the new parameter