Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed from_preset file downloading to use GFile when able #1665

Merged
merged 7 commits into from
Jun 15, 2024

Conversation

VarunS1997
Copy link
Collaborator

To better support Google product usage when there are authentication barriers, we will use GFile-based processes.

As a result, gcloud auth should function as expected.

keras_nlp/src/utils/preset_utils.py Outdated Show resolved Hide resolved
keras_nlp/src/utils/preset_utils.py Outdated Show resolved Hide resolved
keras_nlp/src/utils/preset_utils.py Outdated Show resolved Hide resolved
keras_nlp/src/utils/preset_utils.py Outdated Show resolved Hide resolved
keras_nlp/src/utils/preset_utils.py Outdated Show resolved Hide resolved
keras_nlp/src/utils/preset_utils.py Outdated Show resolved Hide resolved
keras_nlp/src/utils/preset_utils.py Outdated Show resolved Hide resolved
keras_nlp/src/utils/preset_utils.py Outdated Show resolved Hide resolved
keras_nlp/src/utils/preset_utils.py Outdated Show resolved Hide resolved
keras_nlp/src/utils/preset_utils.py Outdated Show resolved Hide resolved
keras_nlp/src/utils/preset_utils.py Outdated Show resolved Hide resolved
keras_nlp/src/utils/preset_utils.py Outdated Show resolved Hide resolved
keras_nlp/src/utils/preset_utils.py Outdated Show resolved Hide resolved
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, but this looks good to me!

keras_nlp/src/utils/preset_utils.py Outdated Show resolved Hide resolved
@mattdangerw mattdangerw added the kokoro:force-run Runs Tests on GPU label Jun 14, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Jun 14, 2024
@VarunS1997 VarunS1997 merged commit a149634 into master Jun 15, 2024
14 checks passed
@VarunS1997 VarunS1997 deleted the feature/GFile-Presets branch June 15, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants