Fix gfile downloads #1666
Merged
Fix gfile downloads #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mattdangerw
commented
Jun 17, 2024
mattdangerw
commented
- Used a local variable that was never set.
- Used a utility from Keras that did not exist.
- Did not handle not found errors properly.
mattdangerw
force-pushed
the
fix-broken-download-logic
branch
from
224136e
to
0a23915
Compare
|
It looks like there's some odd Keras 2 failure that is related to dependency changes and not this PR. Might just ignore it as we will drop Keras 2 support soon anyway. |
Previous version seemed to be broken - Used a local variable that was never set. - Used a utility from Keras that did not exist. - Did not handle not found errors properly.
mattdangerw
force-pushed
the
fix-broken-download-logic
branch
from
0a23915
to
f5dafde
Compare
VarunS1997
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.