Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SentencePieceTrainer #281

Merged
merged 11 commits into from
Aug 17, 2022
Merged

SentencePieceTrainer #281

merged 11 commits into from
Aug 17, 2022

Conversation

aflah02
Copy link
Collaborator

@aflah02 aflah02 commented Aug 1, 2022

Fixes #249

@chenmoneygithub
Copy link
Contributor

@aflah02 Thanks for the PR! Could you share a colab on how to use this trainer? and btw, what's the time cost for training wikipedia-en?

chenmoneygithub
chenmoneygithub suggested changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! dropped some comments

keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Outdated Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Outdated Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Outdated Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Outdated Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Outdated Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Outdated Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer_test.py Outdated Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Outdated Show resolved Hide resolved
mattdangerw
mattdangerw requested changes Aug 8, 2022
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Left some comments

keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Outdated Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Outdated Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Outdated Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Outdated Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Outdated Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Outdated Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Outdated Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Show resolved Hide resolved
keras_nlp/tokenizers/sentence_piece_tokenizer_trainer_test.py Outdated Show resolved Hide resolved
mattdangerw
mattdangerw approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some minor copy edits, and one comment re file closing. Make sure to pull the copy edits in locally.

Approving pending that one final comment! Thanks!

keras_nlp/tokenizers/sentence_piece_tokenizer_trainer.py Show resolved Hide resolved
mattdangerw
mattdangerw approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chenmoneygithub chenmoneygithub merged commit 1db68a7 into keras-team:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdangerw mattdangerw mattdangerw approved these changes

@chenmoneygithub chenmoneygithub chenmoneygithub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a model proto training utility for sentence piece
3 participants
@aflah02 @chenmoneygithub @mattdangerw