Fixes for WordPieceTrainer #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdangerw
requested changes
Aug 11, 2022
mattdangerw
reviewed
Aug 11, 2022
|
Ah sorry about that missed they are input files and not vocab files |
mattdangerw
added a commit
that referenced
this pull request
Aug 11, 2022
* update default to * style fixes * updated lowercase default * lowercase tokenizer trainer default * style fixes * updated default * Fixes for WordPieceTrainer (#293) * Changed to temp_dir * Addressed Review Comments * Addressed Reviews * Edits Co-authored-by: Matt Watson <1389937+mattdangerw@users.noreply.github.com> * fixed rebase * style fixes Co-authored-by: Aflah <72096386+aflah02@users.noreply.github.com> Co-authored-by: Matt Watson <1389937+mattdangerw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed to remove dependency between docstring tests and other tests for file removal