Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🚨 Fix flake8 warnings #779

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

Anselmoo
Copy link
Contributor

@Anselmoo Anselmoo commented Dec 5, 2022

Fixes #778 issues with setup.cfg.

  1. Add staticmethod
  2. Fix in @classmethod
  3. Add pep8-naming-exceptions back for sklearn

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022

Codecov Report

Base: 95.10% // Head: 95.10% // No change to project coverage 👍

Coverage data is based on head (42816b4) compared to base (41693aa).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 42816b4 differs from pull request most recent head 35c1a97. Consider uploading reports for the commit 35c1a97 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #779   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files          46       46           
  Lines        3087     3087           
=======================================
  Hits         2936     2936           
  Misses        151      151           
Impacted Files Coverage Δ
keras_tuner/engine/conditions.py 88.67% <ø> (ø)
keras_tuner/engine/trial.py 97.16% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Anselmoo Anselmoo marked this pull request as ready for review December 5, 2022 11:31
Copy link
Collaborator

@haifeng-jin haifeng-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I cannot reproduce the flake8 errors on master. Can you reproduce it in the Codespace environment?

@haifeng-jin
Copy link
Collaborator

May be using flake8 --version to print the version and plugins for comparison.
Here is mine:
6.0.0 (mccabe: 0.7.0, pycodestyle: 2.10.0, pyflakes: 3.0.1) CPython 3.8.15 on Linux

@haifeng-jin haifeng-jin self-assigned this Dec 5, 2022
@Anselmoo
Copy link
Contributor Author

Anselmoo commented Dec 5, 2022

May be using flake8 --version to print the version and plugins for comparison.
Here is mine:
6.0.0 (mccabe: 0.7.0, pycodestyle: 2.10.0, pyflakes: 3.0.1) CPython 3.8.15 on Linux

That's exactly the problem ... and sorry

Code Space (is working)

6.0.0 (mccabe: 0.7.0, pycodestyle: 2.10.0, pyflakes: 3.0.1) CPython 3.8.15 on Linux

Locally via pyenv 3.10.6:miniconda3-latest

4.0.1 (mccabe: 0.6.1, naming: 0.10.0, pycodestyle: 2.8.0, pyflakes: 2.4.0) CPython 3.10.6 on Darwin

Maybe make a requirements-dev.txt sense?

@haifeng-jin
Copy link
Collaborator

@Anselmoo I guess it is the naming package is making the difference.
Everything that required for dev is managed by the setup.py file.
So would you please update the PR by adding the naming package to setup.py (in the "tests" section)?

@Anselmoo
Copy link
Contributor Author

Anselmoo commented Dec 7, 2022

@Anselmoo I guess it is the naming package is making the difference.
Everything that required for dev is managed by the setup.py file.
So would you please update the PR by adding the naming package to setup.py (in the "tests" section)?

I am not sure if this https://pypi.org/project/naming/ should be added?

However, it was my fault for incorrectly installing it, therefore I add a comment in the contributor notes.

@haifeng-jin haifeng-jin merged commit d27400c into keras-team:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flake8 exceptions are incomplete
3 participants