-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[keras/datasets] Standardise docstring usage of "Default to" #17955
Merged
copybara-service
merged 4 commits into
keras-team:master
from
SamuelMarks:keras.datasets-defaults-to
Apr 26, 2023
Merged
[keras/datasets] Standardise docstring usage of "Default to" #17955
copybara-service
merged 4 commits into
keras-team:master
from
SamuelMarks:keras.datasets-defaults-to
Apr 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing usage of "Default to"
google-ml-butler
bot
added
the
keras-team-review-pending
Pending review by a Keras team member.
label
Apr 13, 2023
qlzh727
requested changes
Apr 19, 2023
Hi @SamuelMarks Can you please resolve conflicts? Thank you! |
gbaned
added
stat:awaiting response from contributor
and removed
keras-team-review-pending
Pending review by a Keras team member.
labels
Apr 21, 2023
# Conflicts: # keras/datasets/imdb.py # keras/datasets/reuters.py
@gbaned Fixed |
qlzh727
approved these changes
Apr 24, 2023
google-ml-butler
bot
added
kokoro:force-run
ready to pull
Ready to be merged into the codebase
labels
Apr 24, 2023
qlzh727
requested changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the lint error.
Fixed |
google-ml-butler
bot
removed
the
ready to pull
Ready to be merged into the codebase
label
Apr 25, 2023
qlzh727
approved these changes
Apr 25, 2023
google-ml-butler
bot
added
kokoro:force-run
ready to pull
Ready to be merged into the codebase
labels
Apr 25, 2023
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 26, 2023
Imported from GitHub PR #17955 This is one of many PRs. Discussion + request to split into multiple PRs @ #17748 Copybara import of the project: -- 5f176b1 by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>: [keras/datasets/imdb.py,keras/datasets/reuters.py] Standardise docstring usage of "Default to" -- 6d271fd by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>: [keras/datasets/reuters.py] Use backticks for defaults in docstrings -- 7ff7ccc by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>: [keras/datasets/reuters.py] Resolve E501 Merging this change closes #17955 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17955 from SamuelMarks:keras.datasets-defaults-to 7ff7ccc PiperOrigin-RevId: 527302425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of many PRs. Discussion + request to split into multiple PRs @ #17748