Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dtype=float32 to PadSequencesTest #19378

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Add dtype=float32 to PadSequencesTest #19378

merged 1 commit into from
Mar 25, 2024

Conversation

qaqland
Copy link
Contributor

@qaqland qaqland commented Mar 25, 2024

For function keras.utils.pad_sequences, it says

sequences: List of sequences (each sequence is a list of integers).

but floats here also work. This commit add test for float type

Modifications to the function itself and document may involve API stability, so no changes have been made, further consideration may be needed

Copy link

google-cla bot commented Mar 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Mar 25, 2024
@fchollet fchollet merged commit f022476 into keras-team:master Mar 25, 2024
8 of 10 checks passed
@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Mar 25, 2024
@qaqland qaqland deleted the add_test_pad_sequences branch March 29, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

4 participants