Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layers): Update Conv2D docstring to clarify numerical precision across backends #20867

Merged

Conversation

harshaljanjani
Copy link
Contributor

  • Make it clear that, contrary to what the Keras 3 docs state, Conv2D operations may exceed the documented 1e-7 precision difference across backends.
  • Document that large convolutions can show notable variations due to accumulated floating-point operations.

Fixes #20804.

…cross backends

Clarify that Conv2D operations may exceed the documented 1e-7 precision difference across backends

Document that large convolutions can show notable variations due to accumulated floating-point operations
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.24%. Comparing base (c04cf9d) to head (3953bf4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20867   +/-   ##
=======================================
  Coverage   82.24%   82.24%           
=======================================
  Files         561      561           
  Lines       52633    52633           
  Branches     8137     8137           
=======================================
  Hits        43288    43288           
  Misses       7340     7340           
  Partials     2005     2005           
Flag Coverage Δ
keras 82.05% <ø> (ø)
keras-jax 64.22% <ø> (ø)
keras-numpy 59.03% <ø> (-0.01%) ⬇️
keras-openvino 32.52% <ø> (ø)
keras-tensorflow 64.85% <ø> (ø)
keras-torch 64.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Feb 6, 2025
@fchollet fchollet merged commit 3906e32 into keras-team:master Feb 6, 2025
6 of 7 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Feb 6, 2025
@harshaljanjani harshaljanjani deleted the fix-conv2d-precision-docs branch February 6, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Results of the Conv2D layer are not identical across backends
4 participants