Switch to pydot 1.2.x #7448
Merged
Switch to pydot 1.2.x #7448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development of `pydot` has now converged [here](https://github.com/erocarrera/pydot), with version 1.2.0 providing the missing Python 3 support. The old `pydot` and `pydot-ng` are no longer maintained.
The repo you linked was last updated 9 months ago... still more up-to-date than the other versions, but I feel like this one is going unmaintained as well. Our reliance on PyDot sucks. But when we assessed our options 2 years ago, we didn't have any better library for Python graph plotting. PR is LGTM |
ahundt
added a commit
to ahundt/keras
that referenced
this pull request
Aug 1, 2017
…ize_input_data * commit '01e2148732e4083b4850345e5ce4dd499cb5999e': (87 commits) Fix common backend styles (keras-team#7476) Allow dynamic shape for repeat_elements (keras-team#7422) Fix test style (keras-team#7473) Crossentropy backend API consistency cleanup (keras-team#7199) Replace the reserved word `input` with `inputs` (keras-team#7474) Increase test coverage (keras-team#7264) Fix l2_normalize Add default value for `l2_normalize`. Remove legacy axis handling in TF backend. Update save_model function (keras-team#7455) Switch to pydot 1.2.x (keras-team#7448) Add save, evaluate and predict functionality for example (keras-team#7430) Docs fix: `pointwise` instead of `depthwise` for SeparableConv2D (keras-team#7444) Fix conv reccurent test Style fix in conv recurrent tests. Support return_state parameter in ConvRecurrent2D (keras-team#7407) Small simplification in ResNet50 architecture Update FAQ with info about custom object loading. add example for passing in custom objects in load_model (keras-team#7420) Update applications.md (keras-team#7428) ... # Conflicts: # tests/keras/backend/backend_test.py
ahundt
added a commit
to ahundt/keras
that referenced
this pull request
Aug 1, 2017
…s_per_epoch * commit '01e2148732e4083b4850345e5ce4dd499cb5999e': (98 commits) Fix common backend styles (keras-team#7476) Allow dynamic shape for repeat_elements (keras-team#7422) Fix test style (keras-team#7473) Crossentropy backend API consistency cleanup (keras-team#7199) Replace the reserved word `input` with `inputs` (keras-team#7474) Increase test coverage (keras-team#7264) Fix l2_normalize Add default value for `l2_normalize`. Remove legacy axis handling in TF backend. Update save_model function (keras-team#7455) Switch to pydot 1.2.x (keras-team#7448) Add save, evaluate and predict functionality for example (keras-team#7430) Docs fix: `pointwise` instead of `depthwise` for SeparableConv2D (keras-team#7444) Fix conv reccurent test Style fix in conv recurrent tests. Support return_state parameter in ConvRecurrent2D (keras-team#7407) Small simplification in ResNet50 architecture Update FAQ with info about custom object loading. add example for passing in custom objects in load_model (keras-team#7420) Update applications.md (keras-team#7428) ...
ahundt
added a commit
to ahundt/keras
that referenced
this pull request
Aug 1, 2017
* commit '01e2148732e4083b4850345e5ce4dd499cb5999e': Fix common backend styles (keras-team#7476) Allow dynamic shape for repeat_elements (keras-team#7422) Fix test style (keras-team#7473) Crossentropy backend API consistency cleanup (keras-team#7199) Replace the reserved word `input` with `inputs` (keras-team#7474) Increase test coverage (keras-team#7264) Fix l2_normalize Add default value for `l2_normalize`. Remove legacy axis handling in TF backend. Update save_model function (keras-team#7455) Switch to pydot 1.2.x (keras-team#7448) Add save, evaluate and predict functionality for example (keras-team#7430) Docs fix: `pointwise` instead of `depthwise` for SeparableConv2D (keras-team#7444) # Conflicts: # keras/backend/cntk_backend.py # keras/backend/theano_backend.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development of
pydothas now converged here, with version 1.2.0 providing the missing Python 3 support. The oldpydotandpydot-ngare no longer maintained.