#9733: Extend RemoteMonitor to send data as application/json #9734
Conversation
There was a problem hiding this comment.
Please a test or extend tests_RemoteMonitor
https://github.com/keras-team/keras/blob/master/tests/keras/test_callbacks.py
keras/callbacks.py
Outdated
|
|
||
| # Arguments | ||
| root: String; root url of the target server. | ||
| path: String; path relative to `root` to which the events will be sent. | ||
| field: String; JSON field under which the data will be stored. | ||
| headers: Dictionary; optional custom HTTP headers. | ||
| send_as_json: whether the request should be send as application/json |
There was a problem hiding this comment.
add the type to be consistent
send_as_json: Boolean, ...
keras/callbacks.py
Outdated
| """ | ||
|
|
||
| def __init__(self, | ||
| root='http://localhost:9000', | ||
| path='/publish/epoch/end/', | ||
| field='data', | ||
| headers=None): | ||
| headers=None, send_as_json=False): |
There was a problem hiding this comment.
skip a line to be consistent
keras/callbacks.py
Outdated
| {self.field: json.dumps(send)}, | ||
| headers=self.headers) | ||
| if self.send_as_json: | ||
| payload = {self.field: send} if self.field else send |
There was a problem hiding this comment.
@Dref360 There is this fragment in the class documentation:
If send_as_json is set to True, the content type of the request will be application/json.
Otherwise the serialized JSON will be send within a form
Do you want me to add something more?
There was a problem hiding this comment.
field can be None and it would also work. But it's not documented in the field doc
There was a problem hiding this comment.
It's also inconsistent with line 593
There was a problem hiding this comment.
@Dref360 the field param makes sense only when the data is sent within the form (the old path), there is no necessity to wrap the data when it is sent as application/json, so I've now simplified the logic and updated the docs.
…(i.e. ignore the field property)
…ack-embeddings-from-layer-outputs * upstream/master: (68 commits) fit/evaluate_generator supporting native tensors (keras-team#9816) keras-team#9642 Add kwarg and documentation for dilation_rate to SeparableConvs (keras-team#9844) Document that "same" is inconsistent across backends with strides!=1 (keras-team#9629) Improve tests by designating dtype of sample data (keras-team#9834) Add documentation for 'subset' and interpolation' arguments (ImageDataGenerator) (keras-team#9817) Revert default theme to readthedocs Various docs fixes. Fix conflict Add support for class methods documentation (keras-team#9751) Add missing verbose opt for evaluate_generator (keras-team#9811) Added `data_format` to flatten layer. (keras-team#9696) Allow saving models directly to binary stream (keras-team#9789) Fix ctc_batch_cost() error when batch_size = 1 (keras-team#9775) Fix keras-team#9802 (keras-team#9803) Fix error in ImageDataGenerator documentation (keras-team#9798) fix typo (keras-team#9792) keras-team#9733: Extend RemoteMonitor to send data as application/json (keras-team#9734) Fixed inconsistencies regarding ReduceLROnPlateau (keras-team#9723) Fix doc issue. General stateful metrics fixes (keras-team#9446) ...
keras-team#9734) * keras-team#9733: Extend RemoteMonitor to send data as application/json
No description provided.