Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add training data for one special error case #813

Closed
wants to merge 15 commits into from

Conversation

lfoppiano
Copy link
Collaborator

@lfoppiano lfoppiano commented Aug 12, 2021

This PR provides the training data to improve the recognition related to error case #632. I've added in the guidelines a couple of additional sentences related to the author contribution as discussed.

Where I was not sure, I commented directly in the XML files.

@lfoppiano lfoppiano requested a review from kermitt2 August 12, 2021 01:07
@lfoppiano lfoppiano changed the title Add training data Add training data for one special error case Aug 12, 2021
@kermitt2
Copy link
Owner

Hello Luca !
Would it be possible to send me the PDF for these training cases?

@lfoppiano
Copy link
Collaborator Author

This is just one document.
The PDF was linked in the issue: https://www.nature.com/articles/s41598-020-58065-9.pdf

@kermitt2
Copy link
Owner

kermitt2 commented Aug 9, 2022

Raw header file need to be regenerated after retraining of the segmentation model, because some content has been added in the segmentation file.

I think it would be better here to roll-back the changes in the guidelines because they will conflict will most recent ones done in other place and they are redundant.

@kermitt2
Copy link
Owner

kermitt2 commented Aug 9, 2022

It might be appropriate to merge this PR with branch feature/data-availability-statement first and not with master, because the changes relatively to training in different branches here make things difficult to follow and update in a consistent manner (the raw files and model in particular).

@lfoppiano
Copy link
Collaborator Author

Thanks for the review! I close this and add these files (without guidelines) directly in the feature/data-availability-statement.

lfoppiano added a commit that referenced this pull request Aug 12, 2022
@kermitt2
Copy link
Owner

closing because it is moved into feature/data-availability-statement

@kermitt2 kermitt2 closed this Sep 25, 2022
@lfoppiano lfoppiano deleted the features/add-training-data-632 branch June 12, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants