Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic timeout on pdfalto_server #926

Merged
merged 7 commits into from
Jul 15, 2022

Conversation

lfoppiano
Copy link
Collaborator

@lfoppiano lfoppiano commented Jun 22, 2022

This PR should add a dynamic timeout on the pdfalto_server script using the argument --timeout XY. #923

It also avoid changing the virtual memory on mac Os. #894

@lfoppiano lfoppiano marked this pull request as draft June 22, 2022 01:52
@lfoppiano lfoppiano marked this pull request as ready for review June 22, 2022 02:14
@coveralls
Copy link

coveralls commented Jun 22, 2022

Coverage Status

Coverage increased (+0.008%) to 39.963% when pulling 6fd7d19 on feature/timeout_pdfalto_server into e06acf4 on master.

@kermitt2
Copy link
Owner

Thanks a lot Luca !

I tested on Linux 64, but not with Mac Os, and it works fine!

Note that it breaks compatibility of grobid-home version 0.7.1 when running version 0.7.2-SNAPSHOT, grobid-home will need to be up-to-date too, but there's no other way to make that happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants