Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix osnoise and timerlat rt-tests #2614

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Fix osnoise and timerlat rt-tests #2614

merged 2 commits into from
Aug 28, 2024

Conversation

musamaanjum
Copy link
Contributor

I've removed a step at execution time and added rtla package which is needed for execution.

@musamaanjum
Copy link
Contributor Author

@laura-nao @nuclearcat I need to generate the rt-bookworm rootfs. I think we have some job in github to generate that rootfs and upload to storage? Can you please paste steps to that here? Maybe I don't have the right permissions. But I should get those permissions to avoid asking other to do this for me.

@laura-nao
Copy link
Contributor

@laura-nao @nuclearcat I need to generate the rt-bookworm rootfs. I think we have some job in github to generate that rootfs and upload to storage? Can you please paste steps to that here? Maybe I don't have the right permissions. But I should get those permissions to avoid asking other to do this for me.

I've used this action to build rootfs images for testing on staging (they end up in https://storage.staging.kernelci.org/rootfs/): https://github.com/kernelci/kernelci-core/actions/workflows/rootfs.yml - not sure about the required permissions though.

@nuclearcat
Copy link
Member

@musamaanjum i added you, please try to generate rootfs image.

@nuclearcat
Copy link
Member

P.S. Attention, first try to generate staging image and test with it, then if everything ok you can generate production image.

@musamaanjum
Copy link
Contributor Author

musamaanjum commented Aug 8, 2024

The following error appears from a test run on 6th August:

+ ./rtla-osnoise.sh -d 60s -w hackbench
./rtla-osnoise.sh: 35: rtla: not found
/lava-15080299/0/tests/0_rt-tests-rtla-osnoise/automated/linux/rtla/output/results/bgcmd/bg_run.sh: line 4: hackbench: command not found

I've confirmed rtla and hackbench are installed in the latest generated rootfs. There was staging-skip on the PR on that day. So the old rootfs have been used for this run. Let's wait for an updated run with the correct rootfs.

@nuclearcat
Copy link
Member

@musamaanjum any updates on this?

@musamaanjum
Copy link
Contributor Author

@musamaanjum any updates on this?

@nuclearcat the latest status is on sister PR: kernelci/kernelci-pipeline#700

The rt-tests-prerq install proccps and rt-tests packages. Both aren't
required. Hence remove it.
- The procps is already present in the image and can be found in
  bookworm-rt of rootfs_configs.
- The rt-tests suite is cloned freshly from its repository and installed
  in the rootfs. We don't need to install the rt-tests package from
  debian repository which would be outdated.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
The rtla package is used in the test-defination os some rt-tests.
Include it in the rootfs.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
@musamaanjum
Copy link
Contributor Author

Rebased the PR

Copy link
Contributor

@pawiecz pawiecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Verified together with kernelci/kernelci-pipeline#700 (details)

@musamaanjum
Copy link
Contributor Author

I've collected the results on kernelci/kernelci-project#439 and fix issues under this ticket. Overall, 3/11 tests have issues in their executor script in https://github.com/Linaro/test-definitions.

@nuclearcat nuclearcat added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit c5424c2 Aug 28, 2024
7 checks passed
@nuclearcat nuclearcat deleted the fix_rt_tests branch August 28, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants