Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootfs:overlays:fluster Add verbose option for fluster parser #2618

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

denisyuji
Copy link
Contributor

@denisyuji denisyuji commented Jul 18, 2024

This is a continuation of the PR #2609 accidentally closed by me.

This change adds --verbose option for fluster parser to make fluster more verbose to facilitate debug. When --verbose is provided, the fluster_parser.py script will forward it to fluster which will enable the verbosity of GStreamer. The GStreamer verbosity facilitates the debug on regressions investigations.
The low verbosity level enabled by fluster adds few hundreds of lines on logs when this option is provided, without significant impact on the performance. Anyways, the verbosity option should be disabled by default on fluster_parser.py and will not be used by kernel-ci pipeline by default.
The intention is to enable users to add --verbose flag manually only when investigating a codec regression.

@denisyuji denisyuji requested a review from laura-nao July 18, 2024 14:28
@denisyuji denisyuji added the staging-skip Don't test automatically on staging.kernelci.org label Jul 18, 2024
@nuclearcat nuclearcat removed the staging-skip Don't test automatically on staging.kernelci.org label Jul 19, 2024
@denisyuji denisyuji force-pushed the fluster-verbose branch 4 times, most recently from 23741f5 to ccbf7b0 Compare July 22, 2024 19:18
@laura-nao
Copy link
Contributor

LGTM! @nuclearcat given the changes are fairly trivial, should we build a new bookworm-gst-fluster image directly for production without going through staging?

@pawiecz
Copy link
Contributor

pawiecz commented Aug 15, 2024

should we build a new bookworm-gst-fluster image directly for production without going through staging?

Agreed, these changes could prove themselves useful in shipping fluster features quicker (no need to change rootfs URLs in templates/configs).

From scheduler entries in kernelci/kernelci-pipeline#705 I see that the main target are arm64 platforms - I triggered a build pipeline for them.

@pawiecz
Copy link
Contributor

pawiecz commented Aug 16, 2024

Image rebuild consistently fails, I posted details on the thread in a Slack channel

@pawiecz
Copy link
Contributor

pawiecz commented Aug 19, 2024

Root cause of the image build failure has been found and patched - staging build artifact.

I'll rebuild the image for production when the patches above get merged.

@pawiecz
Copy link
Contributor

pawiecz commented Aug 21, 2024

Patches were merged, building bookworm-gst-fluster images is back to normal since 20240819.0.

@denisyuji please rebase this PR if you need -v available in fluster_parser.py for debugging/investigations - I'll trigger image creation.

add `--verbose` option for fluster parser to make fluster more verbose
to facilitate debug

Signed-off-by: Denis Yuji Shimizu <denis.shimizu@collabora.com>
@denisyuji
Copy link
Contributor Author

Thank you @pawiecz , rebase is done

@nuclearcat nuclearcat added this pull request to the merge queue Aug 27, 2024
Merged via the queue into kernelci:main with commit 9faec3e Aug 27, 2024
4 checks passed
@pawiecz
Copy link
Contributor

pawiecz commented Aug 27, 2024

Updated images are available but I wasn't able to verify them by reusing TestJob definitions from related PRs (details)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants