Skip to content

Commit

Permalink
mm-remove-redundant-check-about-fault_flag_allow_retry-bit-checkpatch…
Browse files Browse the repository at this point in the history
…-fixes

WARNING: Block comments use a trailing */ on a separate line
torvalds#407: FILE: arch/s390/mm/fault.c:459:
+			 * mmap_lock has not been released */

total: 0 errors, 1 warnings, 444 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/mm-remove-redundant-check-about-fault_flag_allow_retry-bit.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Qi Zheng <zhengqi.arch@bytedance.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
akpm00 authored and broonie committed Dec 10, 2021
1 parent 7a88d32 commit d52b16f
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions arch/s390/mm/fault.c
Original file line number Diff line number Diff line change
Expand Up @@ -455,8 +455,10 @@ static inline vm_fault_t do_exception(struct pt_regs *regs, int access)
if (fault & VM_FAULT_RETRY) {
if (IS_ENABLED(CONFIG_PGSTE) && gmap &&
(flags & FAULT_FLAG_RETRY_NOWAIT)) {
/* FAULT_FLAG_RETRY_NOWAIT has been set,
* mmap_lock has not been released */
/*
* FAULT_FLAG_RETRY_NOWAIT has been set, mmap_lock has
* not been released
*/
current->thread.gmap_pfault = 1;
fault = VM_FAULT_PFAULT;
goto out_up;
Expand Down

0 comments on commit d52b16f

Please sign in to comment.