Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Add responsive layout #8

Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
4df03eb
temporarily remove EuiResizableContainer
andreadelrio Sep 14, 2020
760b84a
need to move button to the right section
andreadelrio Sep 15, 2020
39cb3b2
working on Fields mobile button
andreadelrio Sep 16, 2020
df9a482
improve Fields button in mobile
andreadelrio Sep 21, 2020
997c00f
didn't really need an extra component
andreadelrio Sep 23, 2020
9e74d0c
available fields accordion
andreadelrio Sep 23, 2020
38acb01
lots of cleanup
andreadelrio Sep 25, 2020
0f8bc2f
i18n for fields
andreadelrio Sep 28, 2020
b2ad20d
Merge master / fix conflicts
kertal Sep 28, 2020
8793fb4
fix No Results screen on mobile
andreadelrio Sep 28, 2020
ee40566
improve Expanded Document flyout in mobile
andreadelrio Sep 29, 2020
709afd9
give tokens color
andreadelrio Sep 29, 2020
8830406
add NotificationBadge to accordions
andreadelrio Sep 29, 2020
e629524
add EuiShowFor and EuiHideFor
andreadelrio Sep 29, 2020
aae3b7e
make NotificationBadges in sidebar consider filters
andreadelrio Sep 30, 2020
e4f3e89
update Filter button on sidebar
andreadelrio Sep 30, 2020
2e30b1e
removed some boostrap and did some cleanup in legacy
andreadelrio Oct 1, 2020
567b6f2
show the flyout in legacy
andreadelrio Oct 1, 2020
03af0ce
Shared state refactoring
kertal Oct 2, 2020
789e469
Fix flyover not showing icons permanetly
kertal Oct 2, 2020
b6d3a93
update loading screens
andreadelrio Oct 2, 2020
8127b20
fix empty state
andreadelrio Oct 5, 2020
4ad36d9
remove fixed height
andreadelrio Oct 6, 2020
88cb1d2
Fix infinite scrolling
kertal Oct 7, 2020
429e4a4
Adapt infinite scrolling, allow user to hide chart in legacy
kertal Oct 7, 2020
fd5fe4f
couple of tiny styling fixes
andreadelrio Oct 7, 2020
9a29cfb
revert
andreadelrio Oct 7, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 26 additions & 29 deletions src/plugins/discover/public/application/_discover.scss
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,13 @@ discover-app {
flex-grow: 1;
display: flex;
overflow: hidden;
}

.dscApp__sidebar {
flex-grow: 0;
flex-basis: auto;
min-width: 250px;
display: flex;
flex-direction: column;
@include euiBreakpoint('xs', 's') {
flex-grow: 0;
flex-wrap: wrap;
margin-left: 0;
margin-right: 0;
overflow-y: auto;
}
}

.dscApp__content {
Expand All @@ -56,7 +55,7 @@ discover-app {

.dscHistogram {
display: flex;
height: 200px;
height: $euiSize * 12.5;
padding: $euiSizeS;
}
// new slimmer layout for data grid
Expand Down Expand Up @@ -86,6 +85,15 @@ discover-app {
display: flex;
overflow: hidden;

@include euiBreakpoint('m', 'l', 'xl') {
margin-right: $euiSize;
margin-bottom: $euiSize;
}

@include euiBreakpoint('xs', 's') {
margin: $euiSizeS;
}

.kbn-table {
margin-bottom: 0;
}
Expand Down Expand Up @@ -138,10 +146,9 @@ discover-app {
}
}

// SASSTODO: replace the padding value with a variable
.dscTable__footer {
background-color: $euiColorLightShade;
padding: 5px 10px;
padding: $euiSizeXS $euiSizeS;
text-align: center;
}

Expand All @@ -150,10 +157,6 @@ discover-app {
flex-direction: column;
display: flex;
overflow: hidden;
h3 {
margin: -20px 0 10px 0;
text-align: center;
}
}

.dscResults__interval {
Expand Down Expand Up @@ -196,28 +199,22 @@ discover-app {
}
}

.dscCollapsibleSidebar__collapseButton {
align-self: flex-start;
&:not(.closed) {
position: relative;
left: -$euiSizeS;
}
}

.dscCollapsibleSidebar {
position: relative;
z-index: $euiZLevel1;

.dscCollapsibleSidebar__collapseButton {
position: absolute;
top: 0;
right: -$euiSizeXL + 4;
cursor: pointer;
z-index: -1;
min-height: $euiSizeM;
min-width: $euiSizeM;
padding: $euiSizeXS * .5;
}

&.closed {
width: 0 !important;
border-right-width: 0;
border-left-width: 0;
.dscCollapsibleSidebar__collapseButton {
right: -$euiSizeL + 4;
}
}
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
.dscNoResults {
@include euiBreakpoint('xs', 's') {
padding: 0 $euiSizeS;
}
max-width: 1000px;
}
18 changes: 18 additions & 0 deletions src/plugins/discover/public/application/components/discover.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,21 @@
}
}
}

.dscSidebar__mobile {
width: 100%;
padding: 0 $euiSizeS $euiSizeS;
.dscSidebar__sectionStatic {
padding: 0;
}
.dscSidebar__mobileButton {
justify-content: space-between;
}
.dscSidebar__mobileBadge {
margin-left: $euiSizeXS;
}
}

.dscSidebarFlyout__header {
align-items: center;
}
Loading