Version lock mmkv gradle dependency #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Recently a large number of Android devices have been unable to load the libmmkv library (
java.lang.UnsatisfiedLinkError: dlopen failed: library "libmmkv.so" not found
).Last week (04/24) MMKV released v1.3.5 which dropped armv7 and x86 support. The
@kesha-antonov/react-native-background-downloader
package defines a wildcard version usingimplementation 'com.tencent:mmkv:+'
which automatically grabbed this update leading to a number of Android devices in production to crash on app start.The
armv7
abi removed is for 32-bit devices with most modern devices beingarm64-v8a
, 64 bit arch. This PR version lockscom.tencent:mmkv
to v1.3.4, the last stable version with all abi support.Deployment
By locking the mmkv version to 1.3.4 and releasing a new npm package version this will allow devices to continue with stable support. Future version of this package can then bump to 1.3.5 and beyond with the developer being able to change their
@kesha-antonov/react-native-background-downloader
version for their needs rather than relying on downstream resolutions.Stacktrace