-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved class resolution #8
Comments
Also pass scopeDescriptor to determineClassName method since it might contain useful information for defining current scope. The autocomplete-plus package gives scopeDescriptor to getSuggestions method of AtomAutocompleteProvider as a parameter. |
Some small improvements also mentioned in issue #31. |
one major issue i've noticed is that i have to wait for a full refresh after opening a file before autocomplete kicks in, and that can take several minutes. is this completely necessary? could the results of a refresh be cached or something so that autocomplete works next time i open the file? |
Class loading is not optimized yet. See issue #13. Caching class descriptions to disk is one way to do it but hopefully not needed. Current implementation should work ok in a scenario where you open a project, code for hours and compile your java files to separate class files. All loaded classes stay in memory until you close Atom window or do full refresh manually. Manual full refresh should rarely be needed since separate class files can be either loaded automatically on save or manually running project refresh. |
…lus, playing with class resolution using scopes, next to come, grammar tokens
Current implementation is just a really quick hack. Pass classloader to AtomJavaUtil.determineClassName() as a parameter and implement more intelligence there. Classloader does not yet contain information about inheritance (check issue #4).
The text was updated successfully, but these errors were encountered: