fix(ui): remove empty arrays overriding default values upon task vali…

…dation in low code closes #4758
kestra-io · Aug 29, 2024 · 3c35c8a · 3c35c8a
1 parent 0d4e8f2
commit 3c35c8a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 20 deletions.
diff --git a/ui/src/components/flows/tasks/TaskArray.vue b/ui/src/components/flows/tasks/TaskArray.vue
@@ -32,13 +32,13 @@
         mixins: [Task],
         emits: ["update:modelValue"],
         created() {
-            if (!Array.isArray(this.modelValue)) {
+            if (!Array.isArray(this.modelValue) && this.modelValue !== undefined) {
                 this.$emit("update:modelValue", []);
             }
         },
         computed: {
             values() {
-                if (this.modelValue === undefined || (Array.isArray(this.modelValue) && this.modelValue.length === 0)) {
+                if (this.modelValue === undefined) {
                     return this.schema.default || [undefined];
                 }
 

diff --git a/ui/src/components/inputs/EditorView.vue b/ui/src/components/inputs/EditorView.vue
@@ -120,10 +120,10 @@
 
     const isCurrentTabFlow = computed(() => currentTab?.value?.extension === undefined)
 
-    const flowErrors = computed(() => {
-        const isFlow = currentTab?.value?.flow;
+    const isFlow = () => currentTab?.value?.flow || props.isCreating;
 
-        if (isFlow) {
+    const flowErrors = computed(() => {
+        if (isFlow()) {
             const flowExistsError =
                 props.flowValidation?.outdated && props.isCreating
                     ? [outdatedMessage.value]
@@ -152,9 +152,7 @@
     });
 
     const flowWarnings = computed(() => {
-        const isFlow = currentTab?.value?.flow;
-
-        if (isFlow) {
+        if (isFlow()) {
             const outdatedWarning =
                 props.flowValidation?.outdated && !props.isCreating
                     ? [outdatedMessage.value]
@@ -283,9 +281,7 @@
     );
 
     const flowHaveTasks = (source) => {
-        const isFlow = currentTab?.value?.flow || props.isCreating; 
-
-        if (isFlow) {
+        if (isFlow()) {
             const flow = props.isCreating ? props.flow.source : (source ? source : flowYaml.value);
             return flow ? YamlUtils.flowHaveTasks(flow) : false;
         } else return false;
@@ -441,10 +437,10 @@
         });
     };
 
-    const onEdit = (event, isFlow = false) => {
+    const onEdit = (event, currentIsFlow = false) => {
         flowYaml.value = event;
 
-        if (isFlow) {
+        if (currentIsFlow) {
             if (
                 flowParsed.value &&
                 !props.isCreating &&
@@ -467,7 +463,7 @@
 
         haveChange.value = true;
         store.dispatch("core/isUnsaved", true);
-        
+
         if(!props.isCreating){
             store.commit("editor/changeOpenedTabs", {
                 action: "dirty",
@@ -480,7 +476,7 @@
 
         clearTimeout(timer.value);
 
-        if(!isFlow) return;
+        if(!currentIsFlow) return;
 
         return store
             .dispatch("flow/validateFlow", {flow: yamlWithNextRevision.value})
@@ -602,13 +598,13 @@
     };
 
     const editorUpdate = (event) => {
-        const isFlow = currentTab?.value?.flow;
+        const currentIsFlow = isFlow();
 
         updatedFromEditor.value = true;
         flowYaml.value = event;
 
         clearTimeout(timer.value);
-        timer.value = setTimeout(() => onEdit(event, isFlow), 500);
+        timer.value = setTimeout(() => onEdit(event, currentIsFlow), 500);
     };
 
     const switchViewType = (event, shouldPersist = true) => {
@@ -722,9 +718,7 @@
             }
         }
 
-        const isFlow = currentTab?.value?.flow || props.isCreating;
-
-        if (isFlow) {
+        if (isFlow()) {
             onEdit(flowYaml.value, true).then((validation) => {
                 if (validation.outdated && !props.isCreating) {
                     confirmOutdatedSaveDialog.value = true;