Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels are not created correctly when deployed by Terraform #2037

Closed
yvrng opened this issue Sep 5, 2023 · 2 comments · Fixed by #2049
Closed

Labels are not created correctly when deployed by Terraform #2037

yvrng opened this issue Sep 5, 2023 · 2 comments · Fixed by #2049
Assignees
Labels
bug Something isn't working

Comments

@yvrng
Copy link
Contributor

yvrng commented Sep 5, 2023

Expected Behavior

When deploying a flow using Terraform, I want the labels to be created correctly.

If I wrote labels in a flow, using the key/value representation, such as

labels:
  env: prd
  country: FR

I want them to be created as following, in the target Kestra server:

labels:
  env: prd
  country: FR

Actual Behaviour

Instead of the expected behavior, the flows created by Terraform don't contain labels. Instead, we get a list with an empty object.

labels:
- {}

We get this unexpected behavior for any flow.

Steps To Reproduce

No response

Environment Information

  • Kestra Version: 0.11.0
  • Operating System (OS / Docker / Kubernetes): Kubernetes
  • Kestra TF Operator Version: 0.7.0

Example flow

No response

@yvrng yvrng added the bug Something isn't working label Sep 5, 2023
@github-project-automation github-project-automation bot moved this to Backlog in All issues Sep 5, 2023
@tchiotludo
Copy link
Member

can you try to update terraform provider version please to 0.10.0 please ?

@yvrng
Copy link
Contributor Author

yvrng commented Sep 6, 2023

Hello!

Indeed, upgrading the TF provider to 0.10.0+ solved our issue. The problem seems to originate from the JSON resource on the web server, which was used to deploy flows in previous versions.

This also involved updating the flows, and adding/uncommenting the id/namespace pairs: they were previously not allowed with the JSON resource, but are now required with the YAML resource. If a flow is created without them, the web server returns an HTTP 401 error without clear explanation.

Thanks for your help,
Yoann

@tchiotludo tchiotludo moved this from Backlog to Ready in All issues Sep 6, 2023
@loicmathieu loicmathieu moved this from Ready to In Progress in All issues Sep 7, 2023
@loicmathieu loicmathieu self-assigned this Sep 7, 2023
@loicmathieu loicmathieu moved this from In Progress to Review in All issues Sep 7, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in All issues Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants