Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better display of skip tasks on topology for execution #241

Closed
tchiotludo opened this issue Dec 3, 2020 · 5 comments · Fixed by kestra-io/ui-libs#5 or #2171
Closed

Better display of skip tasks on topology for execution #241

tchiotludo opened this issue Dec 3, 2020 · 5 comments · Fixed by kestra-io/ui-libs#5 or #2171
Assignees
@brian-mulier-p
Labels
enhancement New feature or request

Comments

@tchiotludo
Copy link
Member

image

When you run a switch and some task are not execute (normally). We don't see clearly that this tasks are skipped.

Maybe just add some opacity on skipped tasks ?
@tchiotludo tchiotludo moved this to Backlog in All issues Oct 28, 2021
@tchiotludo tchiotludo moved this from Backlog to Ready in All issues Oct 29, 2021
@tchiotludo tchiotludo moved this from Ready to Backlog in All issues Jan 24, 2023
@tchiotludo tchiotludo moved this from Backlog to Ready in All issues Feb 21, 2023
@Ben8t
Copy link
Member

Ben8t commented Apr 12, 2023

Enhanced since recent versions (cf screenshots), but still agree about changing the opacity for non executed tasks

Image

@Ben8t Ben8t added the P3 ⭐ label Apr 24, 2023
@Ben8t Ben8t added enhancement New feature or request and removed P3 ⭐ labels May 5, 2023
@Ben8t Ben8t added this to the 0.11.0 milestone May 10, 2023
@yuri1969
Copy link
Contributor

yuri1969 commented Jun 2, 2023

Here is a bit of feedback obtained during an internal UI presentation: The topology view should convey the taken path of the execution. This means it must be easy to tell which nodes and edges took a part in the execution.

Crude example:
path

@Ben8t Ben8t moved this from Ready to Backlog in All issues Jun 26, 2023
@Ben8t Ben8t added the triage label Jun 30, 2023
@Ben8t
Copy link
Member

Ben8t commented Jun 30, 2023

epic at #1670

@Ben8t Ben8t removed the triage label Jun 30, 2023
@Ben8t Ben8t mentioned this issue Jul 4, 2023
Closed
@Ben8t Ben8t moved this from Backlog to In Progress in All issues Aug 3, 2023
@tchiotludo
Copy link
Member Author

@Nico-Kestra : we don't have a design on that one

@tchiotludo tchiotludo removed this from the 0.11.0 milestone Aug 28, 2023
tchiotludo added a commit to kestra-io/ui-libs that referenced this issue Aug 29, 2023
@tchiotludo
fix: better display of disabled tasks
fa15566 
relate to kestra-io/kestra#241
@tchiotludo tchiotludo moved this from In Progress to Ready in All issues Aug 29, 2023
@tchiotludo
Copy link
Member Author

I think about using opacity to hide the unused edge, it's not complex but we need to forward the taskId to the edge to be able to know if the target edge is visible or not

@brian-mulier-p brian-mulier-p moved this from Ready to In Progress in All issues Sep 21, 2023
@brian-mulier-p brian-mulier-p self-assigned this Sep 22, 2023
brian-mulier-p added a commit that referenced this issue Sep 25, 2023
@brian-mulier-p
feat(ui): reduced opacity on unused paths
b75fe54 
closes #241
brian-mulier-p added a commit to kestra-io/ui-libs that referenced this issue Sep 25, 2023
@brian-mulier-p
feat(ui): reduced opacity on unused paths
7bd2f42 
closes kestra-io/kestra#241
This was referenced Sep 25, 2023
Merged
Merged
@brian-mulier-p brian-mulier-p moved this from In Progress to Review in All issues Sep 25, 2023
brian-mulier-p added a commit to kestra-io/ui-libs that referenced this issue Sep 25, 2023
@brian-mulier-p
feat(ui): reduced opacity on unused paths
a9cdb89 
closes kestra-io/kestra#241
brian-mulier-p added a commit to kestra-io/ui-libs that referenced this issue Sep 25, 2023
@brian-mulier-p
feat(ui): reduced opacity on unused paths
436afe8 
closes kestra-io/kestra#241
brian-mulier-p added a commit that referenced this issue Sep 25, 2023
@brian-mulier-p
feat(ui): reduced opacity on unused paths
f765b12 
closes #241
brian-mulier-p added a commit to kestra-io/ui-libs that referenced this issue Sep 25, 2023
@brian-mulier-p
feat(ui): reduced opacity on unused paths
5e5f940 
closes kestra-io/kestra#241
brian-mulier-p added a commit to kestra-io/ui-libs that referenced this issue Sep 26, 2023
@brian-mulier-p
feat(ui): reduced opacity on unused paths
3ae18fb 
closes kestra-io/kestra#241
brian-mulier-p added a commit to kestra-io/ui-libs that referenced this issue Sep 26, 2023
@brian-mulier-p
feat(ui): reduced opacity on unused paths
1f9a193 
closes kestra-io/kestra#241
@github-project-automation github-project-automation bot moved this from Review to Done in All issues Sep 26, 2023
brian-mulier-p added a commit that referenced this issue Sep 26, 2023
@brian-mulier-p
feat(ui): reduced opacity on unused paths
dc191c2 
closes #241
brian-mulier-p added a commit that referenced this issue Sep 26, 2023
@brian-mulier-p
feat(ui): reduced opacity on unused paths
eceffe9 
closes #241
brian-mulier-p added a commit that referenced this issue Sep 26, 2023
@brian-mulier-p
feat(ui): reduced opacity on unused paths
9b505aa 
closes #241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-mulier-p brian-mulier-p

Labels
enhancement New feature or request
Projects
No open projects
All issues
Archived in project
Milestone
No milestone
4 participants
@tchiotludo @yuri1969 @brian-mulier-p @Ben8t