Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI doesn't let you select TIME or DURATION input types at execution if defaults set #3697

Closed
Tracked by #4656
wrussell1999 opened this issue May 10, 2024 · 1 comment · Fixed by #4955
Closed
Tracked by #4656
Assignees
Labels
area/frontend Needs frontend code changes bug Something isn't working

Comments

@wrussell1999
Copy link
Member

wrussell1999 commented May 10, 2024

Describe the issue

When setting a default value for TIME or DURATION, the execute interface doesn't recognise them, and refuses to let you override it. If you remove the default values, the UI works as expected. If the TIME and DURATION don't support defaults, it would be helpful to show an error to the user.

Also the duration type gives you a time picker in the UI, rather than a duration option:
Screenshot 2024-05-10 at 11 42 24

This doesn't work:

inputs:
  - id: time
    type: TIME
    defaults: "11:01:01" 

  - id: duration
    type: DURATION
    defaults: PT2M

To get it to work, you need to remove the defaults but it's unclear that is the problem (see video):

inputs:
  - id: time
    type: TIME

  - id: duration
    type: DURATION
Input.Error.-.HD.1080p.mov

Environment

  • Kestra Version: 16.6
  • Operating System (OS/Docker/Kubernetes): macOS
  • Java Version (if you don't run kestra in Docker):
@wrussell1999 wrussell1999 added the bug Something isn't working label May 10, 2024
@wrussell1999 wrussell1999 changed the title Inputs Interface doesn't let you select time or duration types if defaults set UI doesn't let you select TIME or DURATION input types at execution if defaults set May 10, 2024
@anna-geller anna-geller added this to the v0.18.0 milestone May 13, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Jun 10, 2024
@anna-geller anna-geller removed this from the v0.18.0 milestone Jul 3, 2024
@anna-geller anna-geller added the area/frontend Needs frontend code changes label Aug 15, 2024
@Skraye Skraye self-assigned this Sep 13, 2024
@Skraye Skraye moved this from Backlog to In progress in Issues Sep 13, 2024
@Skraye Skraye closed this as completed in cc49dc4 Sep 17, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Issues Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants