-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new ForEach topology show task in "parallel" while concurrency is set to 1 #4474
Comments
I can confirm topology view is not correct even though backend-wise everything is fine (see execution is correctly running each task groups sequentially one after the other rather than in parallel as shown in the topology view): id: test_for_each
namespace: kestra.qa
tasks:
- id: for_each
type: io.kestra.plugin.core.flow.ForEach
values: ['value1', 'value2', 'value3']
concurrencyLimit: 1
tasks:
- id: log1
type: io.kestra.plugin.core.log.Log
message: "{{ taskrun.value }}"
- id: log2
type: io.kestra.plugin.core.log.Log
message: "{{ taskrun.value }}"
- id: log3
type: io.kestra.plugin.core.log.Log
message: "{{ taskrun.value }}" @MilosPaunovic can you have a look? the tasks in the group should be shown as a sequential group within ForEach |
As I am far away from being an expert for this Right now the response of the endpoint returning the data for graph looks like this: [
// ...
{
"uid": "root.for_each.log1",
"type": "io.kestra.core.models.hierarchies.GraphTask",
"error": false,
"task": {
"id": "log1",
"type": "io.kestra.plugin.core.log.Log",
"message": "{{ taskrun.value }}"
},
"relationType": "PARALLEL"
},
{
"uid": "root.for_each.log2",
"type": "io.kestra.core.models.hierarchies.GraphTask",
"error": false,
"task": {
"id": "log2",
"type": "io.kestra.plugin.core.log.Log",
"message": "{{ taskrun.value }}"
},
"relationType": "PARALLEL"
},
{
"uid": "root.for_each.log3",
"type": "io.kestra.core.models.hierarchies.GraphTask",
"error": false,
"task": {
"id": "log3",
"type": "io.kestra.plugin.core.log.Log",
"message": "{{ taskrun.value }}"
},
"relationType": "PARALLEL"
}
// ...
] Notice the Possibly @loicmathieu could be the one who knows the answer to that? |
Yes this is a backend issue not a frontend issue. |
Describe the issue
When using the new ForEach task with
concurency: 1
the topology still show tasks like if they were run in parallel. Not a big issue but could mislead users - especially those used to EachSequential +concurrency: 1
is the default valueEnvironment
The text was updated successfully, but these errors were encountered: