Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new filter/search bar for Flows and Executions #4664

Open
5 tasks
anna-geller opened this issue Aug 14, 2024 · 11 comments
Open
5 tasks

Introduce new filter/search bar for Flows and Executions #4664

anna-geller opened this issue Aug 14, 2024 · 11 comments
Assignees
Labels
area/frontend Needs frontend code changes enhancement New feature or request kind/highlight One of the highlights of the upcoming release

Comments

@anna-geller
Copy link
Member

anna-geller commented Aug 14, 2024

Feature description

With the growing number of filters, this filter/search bar is cluttered:

image

It would be great to implement a similar approach to GitLab's filter -- Walkthrough: https://share.descript.com/view/N8dV18u74Um

Related issues

Issues that will be enabled/improved by this:

@anna-geller anna-geller added the enhancement New feature or request label Aug 14, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Aug 14, 2024
@anna-geller anna-geller added the area/frontend Needs frontend code changes label Aug 14, 2024
@MilosPaunovic MilosPaunovic self-assigned this Aug 26, 2024
@VamshiReddy02
Copy link

Hey @MilosPaunovic, can I work on this issue? because there is currently no associated pull request for this issue.

@MilosPaunovic
Copy link
Member

@VamshiReddy02 Absolutely, go for it! 🚀

@anna-geller anna-geller added the good first issue Great issue for new contributors label Oct 10, 2024
@MilosPaunovic
Copy link
Member

@VamshiReddy02 Any progress on this?

@anna-geller
Copy link
Member Author

@VamshiReddy02 here is a design how this can look like -- if you can't manage, don't worry we understand, it's a complex feature

image

image

Internal figma link

@anna-geller
Copy link
Member Author

anna-geller commented Oct 22, 2024

History of past searches + Saved searches

image

@Skraye can you assess whether enabling a history of past searches needs storing this somewhere, or would we only cache it on the front-end side?

@Skraye
Copy link
Member

Skraye commented Oct 22, 2024

As current state, we could only store it on the frontend side

@anna-geller anna-geller added kind/highlight One of the highlights of the upcoming release and removed good first issue Great issue for new contributors labels Oct 23, 2024
@anna-geller
Copy link
Member Author

anna-geller commented Oct 25, 2024

  • Relative date is a dedicated filter separate from Absolute one
  • Absolute date is a separate filter with a date range picker
  • Trigger execution ID field is not needed anymore for now due to correlationId
  • only when you type Enter, we filter the data
  • View elements separate from filters:
    • which columns should show in the table
    • whether to show chart
    • refresh toggle
    • the column selector will be on the right
  • Save button for Saved searches
  • Sorting is already handled by the columns in each table
  • For now, we only focus on filters for which we have backend implementation e.g. no multi-select of namespaces until it's done on the backend side
  • For search, user can just type:
    image

long term we could add recent/all for dropdown values e.g. for namespace field

image

@sachinks07
Copy link
Contributor

Can I give a try on this.

@MilosPaunovic
Copy link
Member

Hey @sachinks07,

We've decided to handle this internaly, but I can loop you in for feedback once there's something to be checked.

Maybe you can look at the issues with good first issue labels and pick something from there?

@sachinks07
Copy link
Contributor

Sure. Thank you

@MilosPaunovic
Copy link
Member

First related PR is merged #5844.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes enhancement New feature or request kind/highlight One of the highlights of the upcoming release
Projects
Status: In progress
Development

No branches or pull requests

5 participants