Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): make executions view more compact #4728

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

yuri1969
Copy link
Contributor

What changes are being made and why?

During an internal feedback session it was revealed the executions view should be as compact as possible. Reportedly, the top chart pushes the executions listing down form the initial viewport.

Added setting which hides the executions view's stats chart.

Feel free to suggest a better way to handle this requirement (or better naming, etc.) 🙂

20240822-223618_snap

@MilosPaunovic MilosPaunovic self-requested a review August 26, 2024 07:14
@MilosPaunovic
Copy link
Member

From a technical perspective, this gets the job done, but I feel that from the product side it might be better to have the toggle somewhere on the Executions page itself, maybe as part of the filters box at the top. @anna-geller WDYT?

@anna-geller
Copy link
Member

can you show the screenshot showing what the PR does? something like a before and after screenshot? hard to judge otherwise

@MilosPaunovic
Copy link
Member

It's basically a toggle which changes the visibility of the graph on the Executions page.

This is with the graph visible (only current approach):
image

And this is with the graph not visible;
image

What my question here is would it make more sense to have toggle for that on the Execution page itself, instead on the settings page as a global setting, like on the image in the PR description.

@yuri1969
Copy link
Contributor Author

Just thinking... The toggle could be renamed to something generic, like Compact look, if you have any other applicable view.

@anna-geller
Copy link
Member

yes please, let's add a toggle "Show chart" by default toggled on 👍

in the future, such toggle will be hidden by default in a clean tag-based filter #4664

Added setting which hides the executions view's stats chart.
@yuri1969
Copy link
Contributor Author

Reworked to a simple persistent toggle named Show Chart:

20240828-234624_snap

@MilosPaunovic MilosPaunovic merged commit 8b7f533 into kestra-io:develop Sep 2, 2024
6 of 7 checks passed
@MilosPaunovic
Copy link
Member

Thanks for contributing @yuri1969! 🚀

@yuri1969 yuri1969 deleted the execs-graph branch September 2, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants