feat: new log task to replace echo task #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchiotludo
requested changes
Mar 10, 2023
loicmathieu
requested changes
Mar 10, 2023
tchiotludo
force-pushed
the
develop
branch
2 times, most recently
from
0f6a784 to
320c925
Compare
Skraye
force-pushed
the
feat/log-task
branch
2 times, most recently
from
32aa057 to
9cda02c
Compare
loicmathieu
requested changes
Mar 15, 2023
| @Getter | ||
| @NoArgsConstructor | ||
| @Schema( | ||
| title = "Simple debugging task that log a renderer value.", |
There was a problem hiding this comment.
Suggested change
| title = "Simple debugging task that log a renderer value.", | |
| title = "Task that log a message in the execution log.", |
Comment on lines
30
to
31
| description = "This task is mostly useful for debugging purpose.\n\n" + | ||
| "This one allow you to logs inputs or outputs variables for example, or to debug some templated functions." |
There was a problem hiding this comment.
I think you can remove this description, people know the purpose of a log
| description = "Can be a string or an array of string", | ||
| anyOf = { | ||
| String.class, | ||
| ArrayList.class |
There was a problem hiding this comment.
Suggested change
| ArrayList.class | |
| String[].class |
There was a problem hiding this comment.
Thanks to this the JSON schema will know that the item in the list must be strings
| String render = runContext.render((String) this.message); | ||
| this.log(logger, this.level, render); | ||
| } else if (this.message instanceof Collection) { | ||
| ArrayList<String> messages = (ArrayList<String>) this.message; |
There was a problem hiding this comment.
Suggested change
| ArrayList<String> messages = (ArrayList<String>) this.message; | |
| Collection<String> messages = (Collection<String>) this.message; |
There was a problem hiding this comment.
Don't cast on implementation, always prefere to use the interface.
If Collection didn't fit, use List instead.
It's a principle called "coding against interface"
| @@ -0,0 +1,116 @@ | |||
| package io.kestra.core.tasks.debugs; | |||
There was a problem hiding this comment.
Should be in the log package not the debug package (the same where the Fetch task will be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write a new log task with a more explicit property that accepts String but also an Array of String.
No tests were written for the echo task. Should I write one for the log task?
close #1046