Add Execution labels #1190
Merged
Add Execution labels #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicmathieu
requested review from
Skraye,
loicmathieu and
tchiotludo
and removed request for
Skraye
loicmathieu
requested changes
Apr 27, 2023
jdbc/src/main/java/io/kestra/jdbc/repository/AbstractJdbcExecutionRepository.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/io/kestra/cli/commands/flows/FlowTestCommand.java
Outdated
Show resolved
Hide resolved
webserver/src/main/java/io/kestra/webserver/controllers/ExecutionController.java
Outdated
Show resolved
Hide resolved
loicmathieu
approved these changes
Apr 28, 2023
webserver/src/main/java/io/kestra/webserver/controllers/ExecutionController.java
Outdated
Show resolved
Hide resolved
* Execution now features labels as the Flow does. * The labels are passed in the same way the Flow inputs. * The label names are prefixed with `label-`. * Executions can be filtered using the labels. Room for improvement: * Index the labels within DB. * Rework the labels/inputs passing - use a custom binding? * Add a label filter to the Execution UI. close kestra-io#906
Co-authored-by: Loïc Mathieu <loikeseke@gmail.com>
…estra-io#1298) Co-authored-by: YannC <ycoornaert@kestra.io>
tchiotludo
pushed a commit
that referenced
this pull request
May 18, 2023
* Add Execution labels * Execution now features labels as the Flow does. * The labels are passed in the same way the Flow inputs. * The label names are prefixed with `label-`. * Executions can be filtered using the labels. Room for improvement: * Index the labels within DB. * Rework the labels/inputs passing - use a custom binding? * Add a label filter to the Execution UI. close #906 Co-authored-by: Loïc Mathieu <loikeseke@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
label-.Room for improvement:
close #906