fix(ui): enhanced email and password length constraint in basic authentication #4261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilosPaunovic
requested changes
Jul 8, 2024
webserver/src/main/java/io/kestra/webserver/services/BasicAuthService.java
Outdated
Show resolved
Hide resolved
|
Awesome man, great job! Thanks for the contribution! 🚀 |
Skraye
pushed a commit
that referenced
this pull request
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are being made and why?
Per issue 3871, we want to add additional requirement for the length of email and password in basic authentication as the current implementation will cause a crash if input credentials are too large. This change includes:
How the changes have been QAed?
Verify that if email and password are too long the frontend will prevent users from signing up.