Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kv-store): after-review fixes #4287

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix(kv-store): after-review fixes #4287

merged 1 commit into from
Jul 9, 2024

Conversation

brian-mulier-p
Copy link
Member

No description provided.

@brian-mulier-p brian-mulier-p self-assigned this Jul 9, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

loicmathieu
loicmathieu approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly loot at it but overall LGTM, better separation of concern ;)

@brian-mulier-p brian-mulier-p merged commit 38b72a2 into develop Jul 9, 2024
9 checks passed
@brian-mulier-p brian-mulier-p deleted the fix/kv-store-review branch July 9, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu approved these changes

Assignees

@brian-mulier-p brian-mulier-p

Labels
None yet
Projects
Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brian-mulier-p @loicmathieu