Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): stop realtime trigger and generate a FAILED execution if … #4288

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

loicmathieu
Copy link
Member

…the publisher cannot be created

Part-of: #1256

Thanks to that, an error when creating the Publisher (so before receiving an event) will generate a failed executions and stop the trigger which will not be restarted except if the trigger is manually disabled/enabled.

There is multiple things to do to improve the behaviour:

  • The log is not visible in the execution log tab itself but only in the flow logs page. This is a known issue, see #2521
  • There is no way to restart a realtime trigger except disabling/re-enabling it in the YAML, we need a button for that in the trigger UI, I created https://github.com/kestra-io/kestra-ee/issues/1350 for that.

@loicmathieu
Copy link
Member Author

The test is failing in develop, merging this.

@loicmathieu loicmathieu merged commit bf32d6f into develop Jul 9, 2024
6 of 8 checks passed
@loicmathieu loicmathieu deleted the feat/realtime-trigger-error-handing branch July 9, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant