Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(task-runners): modify task runner implementation so that it has every files from working directory #4291

Merged
merged 1 commit into from
Jul 10, 2024
Merged

feat(task-runners): modify task runner implementation so that it has every files from working directory #4291

merged 1 commit into from
Jul 10, 2024

Conversation

brian-mulier-p
Copy link
Member

No description provided.

@brian-mulier-p brian-mulier-p self-assigned this Jul 9, 2024
loicmathieu
loicmathieu requested changes Jul 10, 2024
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the change requested to protect against path traversal, it's all good!
The code is simpler like that ;)

core/src/main/java/io/kestra/core/models/tasks/runners/ScriptService.java Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@brian-mulier-p brian-mulier-p merged commit f35c979 into develop Jul 10, 2024
8 of 9 checks passed
@brian-mulier-p brian-mulier-p deleted the feat/task-runners-wdir-rework branch July 10, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu requested changes

Assignees

@brian-mulier-p brian-mulier-p

Labels
None yet
Projects
Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brian-mulier-p @loicmathieu