fix(core): keep key order when rendering a Map #4313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
VariableRenderer#render()
method currently uses aHashMap
to store rendered values, and thisMap
implementation does not preserve order.This causes a problem when the
in
parameter is aLinkedHashMap
, and you want the order to be preserved.For example, when using the
Produce
task in the Kafka plugin (here) with an Avro serializer: the event value is part of themap
that is first rendered; the order of the keys must be preserved in order to respect the schema, and currently this leads to serialization problems.I changed it to
LinkedHashMap
, ensuring that key ordering is maintained in case aLinkedHashMap
is passed as an input.