Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update ForEach examples and docs #4398

Merged
merged 3 commits into from
Jul 23, 2024
Merged

docs: update ForEach examples and docs #4398

merged 3 commits into from
Jul 23, 2024

Conversation

anna-geller
Copy link
Member

@anna-geller anna-geller commented Jul 22, 2024

Renamed concurrency to concurrencyLimit since concurrency: 0 doesn't seem to imply that everything will run concurrently, quite the opposite — some might think that this means no concurrency at all. I feel like concurrencyLimit: 0 more clearly indicates that there are no limits in concurrency and all task groups can run concurrently.

also changed some wording and examples

@loicmathieu can you check if any tests must be adjusted for that renaming?

Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like the notion of "task groups" which clearly describe what it is.

Tests was not updated with concurrencyLimit so they fail, I fix it, let's wait for CI before merging.

@loicmathieu loicmathieu merged commit 021dfa0 into develop Jul 23, 2024
5 of 8 checks passed
@loicmathieu loicmathieu deleted the docs/foreach branch July 23, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants