Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/waitfor issue #4421

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Fix/waitfor issue #4421

merged 3 commits into from
Jul 25, 2024

Conversation

Skraye
Copy link
Member

@Skraye Skraye commented Jul 24, 2024

Children's tasks from WaitFor are now executed in the correct order after the first loop.

As it required to clean all taskRuns (previously, we were just erasing the state to make them run again with a new iteration),
the current log view will only display the log from the last task execution.

So I've added a new button that shows a raw list of the logs, which will close #2521 at the same time:

image

To make our logs cleaner, we would need to rework our log components. Currently, we go from the flow's taskRuns list to the logs, but this doesn't allow us to display flow logs or delete taskRun logs.

We would need to reverse that, so we would go from the logs and group them by taskId if needed. This "raw view" is only here to offer a temporary solution.

close #4092

Copy link

sonarcloud bot commented Jul 25, 2024

@Skraye Skraye merged commit 89af5cb into develop Jul 25, 2024
9 checks passed
@Skraye Skraye deleted the fix/waitfor-issue branch July 25, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants