Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FlowRun): Enter key validate inputs form and trigger the execution #960

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

Skraye
Copy link
Member

@Skraye Skraye commented Feb 6, 2023

Pressing enter in the flowRun component now trigger the execution.

To keep possibility to add newline in text-area form use for JSON, the shortcut shit + enter is now available to creating newline

close #903

ui/src/components/flows/FlowRun.vue Outdated Show resolved Hide resolved
ui/src/components/flows/FlowRun.vue Show resolved Hide resolved
@@ -13,6 +13,7 @@
:prop="input.name"
>
<el-input
@keydown.enter.prevent
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugly hack due to VueJS bug where submit is triggered while pressing enter when focus is on input.

@tchiotludo tchiotludo merged commit 69495d7 into develop Feb 6, 2023
@tchiotludo tchiotludo deleted the fix/903-enter-key-close-window branch February 6, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When attempting a new execution on the UI, pressing enter closes the window
2 participants