Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/pad end tflite #131

Merged
merged 18 commits into from
Nov 13, 2021

Conversation

kenders2000
Copy link
Contributor

Fix an issue that was calculating the padding to be applied when using the pad_end parameter incorrectly. issue #124 (sorry for the delay I forgot to fix this in the main Kapre fork!)

Also added some documentation highlighting the restrictions to a batch size of one for the tflite compatible layers as raised in issue #130

@keunwoochoi
Copy link
Owner

hi, thanks for the PR! i'm struggling to fix travis issue now, just fyi.

@kenders2000
Copy link
Contributor Author

Hi thanks for that, I'm not sure what the issue is, I wonder if it is related to merging from a fork rather than a branch, although we did this before...

@keunwoochoi
Copy link
Owner

oh, no worries.
it's just my configuration with travis.

@keunwoochoi keunwoochoi changed the base branch from master to kapre-0.3.6 November 13, 2021 23:37
@keunwoochoi keunwoochoi merged commit 6fb9d2b into keunwoochoi:kapre-0.3.6 Nov 13, 2021
keunwoochoi added a commit that referenced this pull request Nov 14, 2021
* Bugfix/pad end tflite (#131)

* update tensorflow requirements to have optional gpu version

* Update README.md

* Update README.md

* update CI

* remove extras requirement

* Add test for pad_end
Fix bug in tflite pad_end logic

* add missing arg

* comment

* better comment

* revert readme to master

* update travis

* Revert readme

* better readme

* test pad end

* Add tflite documentation

* with

* Add comment and formatting

Co-authored-by: Paul Kendrick <paul.kendrick@musictribe.com>

* bump version to 0.3.6

* reformat

* add release note

Co-authored-by: Paul Kendrick <kenders2000@gmail.com>
Co-authored-by: Paul Kendrick <paul.kendrick@musictribe.com>
@keunwoochoi
Copy link
Owner

@kenders2000 merged, thanks!

@kenders2000 kenders2000 deleted the bugfix/pad_end_tflite branch December 24, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants