Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version() and isIP() returning unexpected results. #25

Closed
STLMikey opened this issue Feb 2, 2021 · 2 comments
Closed

version() and isIP() returning unexpected results. #25

STLMikey opened this issue Feb 2, 2021 · 2 comments

Comments

@STLMikey
Copy link

STLMikey commented Feb 2, 2021

Forgot to sanitize an input, and ended up passing the string "1" to version() and isIP().

version("1"); // returns 4
isIP("1"); // returns true

@amirbardugo
Copy link

@STLMikey the issue is in ipaddr.js apparently whitequark/ipaddr.js#44
they have another function that ignore it @keverw anyway to switch to this one?
ipaddr.IPv4.isValidFourPartDecimal

@keverw keverw closed this as completed in ffc56d4 Jun 28, 2024
@keverw
Copy link
Owner

keverw commented Jun 28, 2024

I decided to upgrade the build scripts, and did this as one of the first fixes. Will be in the future 3.0 release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants