Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPv4 validation not working properly #44

Closed
rskvirskiy opened this issue Jun 14, 2016 · 2 comments
Closed

IPv4 validation not working properly #44

rskvirskiy opened this issue Jun 14, 2016 · 2 comments

Comments

@rskvirskiy
Copy link

ipaddr.IPv4.isValid("1231233") returns true .
But actually this is not valid IPv4.
@whitequark
Copy link
Owner

Nope, it is, according to inet_aton, which is the language that ipaddr.js recognizes: http://linux.die.net/man/3/inet_aton

@whitequark whitequark mentioned this issue Jun 22, 2016
Closed
@whitequark
Copy link
Owner

See ipaddr.IPv4.isValidFourPartDecimal in the 1.2.0 release.

@whitequark whitequark mentioned this issue Jan 1, 2017
Closed
@whitequark whitequark mentioned this issue Feb 17, 2017
Closed
@whitequark whitequark mentioned this issue Mar 31, 2017
Closed
@whitequark whitequark mentioned this issue Apr 29, 2017
Closed
@whitequark whitequark mentioned this issue Feb 1, 2018
Closed
@whitequark whitequark mentioned this issue May 19, 2018
Closed
@whitequark whitequark mentioned this issue Jun 17, 2020
Closed
@kennethtran93 kennethtran93 mentioned this issue Jul 31, 2020
Closed
@amirbardugo amirbardugo mentioned this issue Mar 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whitequark @rskvirskiy