-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement module packing using ncc
#18
Conversation
This has to be removed since `ncc` produces different/randomized constant output each time and will be different from upstream.
I know it seems like a lot of changes, this is basically what I did:
things to mention:
in general i do think we could debloat this repository a lot from all the mostly useless quirks / packages, let me know what your thoughts. also if it wasn't clear from my last comment, right now this repository upstream is non-functional, meaning any workflow targetting this action from and last but not least, let's be consistent on our versioning scheme, is it |
side question - could i become a maintainer? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments. I unpublished v2.0.0 in the meantime. Overall this seems like a good change though!
Are we doing a new release candidate? @kevin-david |
@Yakov5776 just pushed it and created two tags, v2.0.1 and v2 |
I would like to figure this out somehow. I don't love the idea of having to review generated javascript (error prone / supply chain attacks). Maybe we just leave
eslint was set up to establish consistent/automatic following conventions in the
this is what's called a pre commit hook (along with some tooling) so all commits follow the same style - just makes for easier reviews & less arguments about style 😄 |
I don't like that idea either, but in terms of the extent of |
I'm just brainstorming. Maybe potentially have a different branch for distribution/deployments which automatically merges any changes from development/main branch powered by a workflow and does the building by itself and only that branch will even have the |
Turns out other people have run into this problem: vercel/ncc#831 #19 fixes it, between my machine and Actions at least. If you run |
oh sick, let me try |
Yup it works, you might want to add a .gitattributes to the repository like |
Reason has been brought up in #13 (comment)