KeyError when replaying proxy tunnel captured sessions (broken in #389, v2.0.0)

[jeking3]

This would appear as:

  File "/home/jking/pyvmomi/.eggs/vcrpy-2.0.1-py3.6.egg/vcr/request.py", line 61, in port
    port = {'https': 443, 'http': 80}[parse_uri.scheme]
KeyError: ''

Changes were made in #389 to allow for CONNECT (tunneling), and also OPTIONS (with path '*') would also work using the same logic. In these cases, the vcr.Request class will store the URI of the request as the contents of the path verbatim (not a uri).

When the cassette replays, there was code to parse the port which was throwing an uncaught exception. The code used to expect all uri to begin with either 'https' or 'http'. Now if the uri does not start with those, the port remains None instead of generating a KeyError.

Added a unit test to prove this as well.

This fixes #414

[jeking3]

Hmm, maybe then it's how pyvmomi is using vcrpy. I'll close this for now since it broke some things.

[jeking3]

This is ready for consideration. vmware/pyvmomi relies on vcrpy and is currently forced to use 1.x due to the issue introduced in 2.0.0. This resolves that issue.

[jeking3]

@kevin1024 this is a regression from 1.x - is there any possibility you could review and merge this? Thanks.

[jeking3]

@kevin1024 this is a regression from 1.x - is there any possibility you could review and merge this? Thanks.

[jeking3]

@kevin1024 this is a regression from 1.x - is there any possibility you could review and merge this? Thanks.

[kevin1024]

Thanks for the poke. I wonder why the tests don’t seem to be running anymore.

[jeking3]

You may need to re-connect Travis CI and AppVeyor.

[jeking3]

FYI tests did run on this when it was first submitted:

https://travis-ci.org/kevin1024/vcrpy/builds/471426759

[arthurHamon2]

@jeking3 can you please rebase your branch with master in order to run travis CI ?
I'll be happy to merge your PR then :)

[jeking3]

All set, passed.

[jeking3]

Next hurdle - I have an upstream change on pyvmomi that depends on this being in a release. It is blocking pyvmomi from moving to v2 of vcrpy. Any idea when the next release will be?

See: vmware/pyvmomi#750

[neozenith]

@jeking3 follow #447 for discussing the next release. Thanks for your contribution.