Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH-1536 kc-toggle doesn't work with duplicated ids #1571

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

lucasnetau
Copy link
Collaborator

@lucasnetau lucasnetau commented Jul 1, 2024

If there is a duplicate ID for an input kc-toggle will not work for the subsequent input due to the for attribute sending the event to the first input.

Fixes #1536

@lucasnetau lucasnetau requested a review from kevinchappell July 1, 2024 06:57
Copy link
Owner

@kevinchappell kevinchappell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider removing or improving KC toggle. It's quite old fashioned.

@kevinchappell kevinchappell merged commit f71b0b4 into kevinchappell:master Jul 4, 2024
1 check passed
@lucasnetau lucasnetau deleted the fix/1536 branch July 5, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when we have two forms in the same page, the toggle checkbox doesn't work in the second form
2 participants