Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from node 16 to node 20 for Github actions and builds #1573

Merged
merged 8 commits into from
Jul 7, 2024

Conversation

lucasnetau
Copy link
Collaborator

Node 16 in GitHub actions is deprecated. Update actions to use node 20 plus dependancy updates to bring it up to node 20 compatibility. In doing do a lot of old unmaintained packages have been removed. Babel, ESlint and Jest updated to recent versions.

There are a few remaining packages that will need to wait for a future update from dependancies (Babel to v8, Jest JS Env, Semantic release)

@lucasnetau lucasnetau requested a review from kevinchappell July 1, 2024 06:56
@lucasnetau
Copy link
Collaborator Author

@kevinchappell my local versions are working fine but another set of eyes on this would be useful.

Copy link
Owner

@kevinchappell kevinchappell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the near future I'd like to upgrade all the way to v22 to take advantage of some of the newer built-in features for testing and task running. The languages repo was upgraded to node 22 and I was able to remove a few dependencies and eslint and prettier were replaced with biomejs.

@kevinchappell kevinchappell self-requested a review July 4, 2024 14:22
@lucasnetau
Copy link
Collaborator Author

I'll rebase package-lock.json and force-push again. This PR will need to be applied before any others to ensure no merge conflicts after semantic release updates the file version

@kevinchappell kevinchappell merged commit 92384e8 into kevinchappell:master Jul 7, 2024
1 check passed
Copy link

github-actions bot commented Jul 7, 2024

🎉 This PR is included in version 3.19.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lucasnetau lucasnetau deleted the fix/1-node branch October 17, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants