Feature/welcome - nothing major, just icons #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincobain2000
force-pushed
the
feature/welcome
branch
from
f9a8ddc
to
3c667d2
Compare
juev
reviewed
Nov 11, 2024
| @@ -114,31 +114,36 @@ func (gb *GoBrew) Interactive(ask bool) { | |||
| fmt.Println() | |||
|
|
|||
| if currentVersion == NoneVersion { | |||
| color.Warnln("GO Installed Version", ".......", currentVersion) | |||
| color.Warnln("🚨 Installed Version", ".......", currentVersion, "⚠️") | |||
There was a problem hiding this comment.
If we use UTF-8 characters, how will this work on remote machines? Or where a different code page is used? Didn't check?
There was a problem hiding this comment.
didn't check. UTF8 support should be there on most machines. User can always use gobrew <command>
This PR only effects the gobrew interactive command.
|
And we need to see what happened to the unit tests. |
|
something is off |
CoverItUp ReportComparison Table - 7 Types 📉
Comparisons Chart -
|
1 similar comment
CoverItUp ReportComparison Table - 7 Types 📉
Comparisons Chart -
|
CoverItUp ReportComparison Table - 7 Types 📉
Comparisons Chart -
|
… to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar.
kevincobain2000
commented
Nov 20, 2024
| @@ -12,7 +12,6 @@ linters: | |||
| - staticcheck | |||
| - dupl | |||
| - errorlint | |||
| - exportloopref | |||
There was a problem hiding this comment.
WARN The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar.
CoverItUp ReportComparison Table - 7 Types 📉
Comparisons Chart -
|
… to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar.
kevincobain2000
commented
Nov 20, 2024
| @@ -58,7 +58,6 @@ func TestJudgeVersion(t *testing.T) { | |||
| // }, | |||
| } | |||
| for _, test := range tests { | |||
| test := test | |||
There was a problem hiding this comment.
╰─$ golangci-lint run ./...
helpers_test.go:61:3: The copy of the 'for' variable "test" can be deleted (Go 1.22+) (copyloopvar)
test := test
^
helpers_test.go:143:3: The copy of the 'for' variable "tt" can be deleted (Go 1.22+) (copyloopvar)
tt := tt
^
helpers_test.go:183:3: The copy of the 'for' variable "tt" can be deleted (Go 1.22+) (copyloopvar)
tt := tt
^
helpers_test.go:216:3: The copy of the 'for' variable "tt" can be deleted (Go 1.22+) (copyloopvar)
tt := tt
^
juev
approved these changes
Nov 20, 2024
| @@ -12,7 +12,6 @@ linters: | |||
| - staticcheck | |||
| - dupl | |||
| - errorlint | |||
| - exportloopref | |||
| @@ -114,31 +114,36 @@ func (gb *GoBrew) Interactive(ask bool) { | |||
| fmt.Println() | |||
|
|
|||
| if currentVersion == NoneVersion { | |||
| color.Warnln("GO Installed Version", ".......", currentVersion) | |||
| color.Warnln("🚨 Installed Version", ".......", currentVersion, "⚠️") | |||
| @@ -58,7 +58,6 @@ func TestJudgeVersion(t *testing.T) { | |||
| // }, | |||
| } | |||
| for _, test := range tests { | |||
| test := test | |||
CoverItUp ReportComparison Table - 7 Types 📉
Comparisons Chart -
|
CoverItUp ReportComparison Table - 7 Types 📉
Comparisons Chart -
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.