-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Team Mutations #800
Merged
Merged
Team Mutations #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhughes27
force-pushed
the
team-mutations
branch
2 times, most recently
from
July 13, 2018 09:58
8eed041
to
c0c7583
Compare
kevinhughes27
force-pushed
the
team-mutations
branch
from
July 15, 2018 09:44
e4fa8b2
to
8ffca3c
Compare
kevinhughes27
force-pushed
the
team-mutations
branch
from
July 16, 2018 09:37
8ffca3c
to
44f95cf
Compare
kevinhughes27
force-pushed
the
team-mutations
branch
from
July 16, 2018 09:40
44f95cf
to
9ef5a02
Compare
… the button. Fix dropdown throwing a warning.
…doing an edit with dirty tracking)
kevinhughes27
force-pushed
the
team-mutations
branch
from
July 16, 2018 09:40
9ef5a02
to
9cc1340
Compare
kevinhughes27
force-pushed
the
team-mutations
branch
from
July 16, 2018 10:26
9cc1340
to
93fe94a
Compare
…ail client side validation
kevinhughes27
force-pushed
the
team-mutations
branch
from
July 17, 2018 08:47
10fdec2
to
deea1c3
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #750
This PR adds the first mutation and hopes to establish some good patterns around Forms and Mutations for Admin Next.
Relay mutations are cool and I like the optimistic update feature that is built in. I played around with the cache to figure out how it works and I learned that mutations always pass the
force
option which clears the whole cache after any mutation in my current setup. This is simple and easy for now. Eventually I might add https://github.com/relay-tools/react-relay-network-modern to do some more advanced things.I got a fragmentContainer working for the division select. This pattern is more interesting that I most recently thought (#785) because even though you have to wire it all together manually Relay seems to add some nice checks to make sure you did it right. If your fragment container isn't passed what it asked for it throws an error.
In the diff right now you can see that I had to make the mutation public to test this locally. It would work on production because of how Rails serves the app it can set the session but locally there is no way for rails to set the session. To fix this I will have to add JWT auth to the app. This is unexpected but its how most people are doing things for their frontends these days. Long term jwt will be needed for my multi client and static pages on custom domains vision. It may also let us remove devise or some devise magic eventually.
Next
Future